feat: Exposing underlying Image properties on Avatar via _image #4592
Conversation
|
@kav is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
kav
changed the title
|
@intergalacticspacehighway @surajahmed or any other maintainer; any chance I could get a review or some notes on this one? Happy to open an issues as well if needed. I've got a few more coming and I'd love to sequence them if possible |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@kav Thanks for working on this ❤️ ! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary
I have several use cases where I need to modify properties on the Avatars underlying image. This change adds _image to the avatar in a similar fashion to other cases e.g. _text
Changelog
[General] [Added] - Added
_imageproperty to Avatar to expose the underlying image propertiesTest Plan
I've been using the patch successfully to drive underlying image tinting based on a focus property. I'm happy to add automated tests if someone can point me in the right direction.
One area I'd question, and ask reviewsers to chime in on, is should the _image props allow override of all props provided by the avatar or are there some that should never be overiden? I.e. is
{..._image}placed correctly in the props order on the Image tag.